-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deprecate CDP for Firefox #12349
Conversation
875f11a
to
f5e87e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + maybe we need a call to action if there encounter issues?
@Lightning00Blade code to action? |
Typo I wanted to say |
f5e87e5
to
b1272bd
Compare
@whimboo PTAL I think on our end we are ready to mark CDP support for Firefox as deprecated |
I thought that we wanted to do that after the announcement that Puppeteer fully supports Firefox via WebDriver BiDi. For me it feels a bit too early. |
@whimboo we are only 13 tests away from feature-parity with CDP and 147 new tests are passing so I think it is fine to nudge users to try WebDriver BiDi and switch over. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed with the team we are fine with this addition. Also because you are not forcing Webdriver BiDi at this point as default which is fine.
972997d
to
c5e8015
Compare
This PR adds a deprecation warning if Chrome DevTools Protocol (CDP) is used for Firefox. Instead CDP, use WebDriver BiDi: