Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add more e2e tests for device request prompt #11185

Closed
wants to merge 9 commits into from
Closed

test: add more e2e tests for device request prompt #11185

wants to merge 9 commits into from

Commits on Nov 22, 2023

  1. add more e2e tests for device request prompt

    @outofambit @thiagowfx
    outofambit authored and thiagowfx committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    268d12d View commit details
    Browse the repository at this point in the history

  2. remove cdp params

    @outofambit @thiagowfx
    outofambit authored and thiagowfx committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    2efcbe7 View commit details
    Browse the repository at this point in the history

  3. nested describe for waitForDevice test

    @outofambit @thiagowfx
    outofambit authored and thiagowfx committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    2e34cfd View commit details
    Browse the repository at this point in the history

  4. nest waitForDevicePrompt

    @outofambit @thiagowfx
    outofambit authored and thiagowfx committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    dba7269 View commit details
    Browse the repository at this point in the history

  5. spruce up timeouts

    @outofambit @thiagowfx
    outofambit authored and thiagowfx committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    b418ed0 View commit details
    Browse the repository at this point in the history

  6. npm run format

    @outofambit @thiagowfx
    outofambit authored and thiagowfx committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    043dd45 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: Nikolay Vitkov <34244704+Lightning00Blade@users.noreply.github.com>
    @outofambit @Lightning00Blade @thiagowfx
    2 people authored and thiagowfx committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    a14c4b4 View commit details
    Browse the repository at this point in the history

  8. add enable WebBluetooth arg

    @outofambit @thiagowfx
    outofambit authored and thiagowfx committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    ae96088 View commit details
    Browse the repository at this point in the history

  9. format expectations

    @thiagowfx
    thiagowfx committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    1787c26 View commit details
    Browse the repository at this point in the history