-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade https-proxy-agent #5243
chore: upgrade https-proxy-agent #5243
Conversation
https-proxy-agent requires agent-base, which currently monkey patches the core https Node module, causing problems in unrelated code. The latest version of https-proxy-agent uses the latest version of agent-base, which no longer does this monkey patching.
@dguo I hope they will make a new release quickly so this issue can be solved using your PR or mine, i really need these fix to be able to use |
@ouraios, agreed. I'm also unable to use |
@mathiasbynens When can we expect the next release of |
"Soon". For now you could try using the npm install puppeteer/puppeteer#master |
What about |
This fix went out with the recent v2.1.0 release. |
https-proxy-agent
requiresagent-base
, which currently monkey patches the core https Node module, causing problems in unrelated code. The latest version ofhttps-proxy-agent
uses the latest version ofagent-base
, which no longer does this monkey patching.Fixes #5230.
#5224 is an alternative fix.