Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types issue: TS2307: Cannot find module 'lighthouse/types/lhr/flow' or its corresponding type declarations #306

Closed
stevenwdv opened this issue Sep 20, 2022 · 2 comments · Fixed by #307
Assignees

Comments

@stevenwdv
Copy link

stevenwdv commented Sep 20, 2022

Expected Behavior

tsc works fine

Actual Behavior

node_modules/@puppeteer/replay/lib/main.d.ts:2:24 - error TS2307: Cannot find module 'lighthouse/types/lhr/flow' or its corresponding type declarations.

Steps to Reproduce the Problem

  1. Install @puppeteer/replay
  2. Reference it in a TypeScript file
  3. Compile TypeScript

Specifications

@OrKoN
Copy link
Collaborator

OrKoN commented Sep 20, 2022

@adamraine could you please take a look? It appears that that a static import for lighthouse types slipped in (but peer dependencies not yet properly defined). Should we revert?

@adamraine
Copy link
Contributor

We don't need to revert the whole thing, just replace the FlowResult type with any until peer deps are added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants