We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pdk-templates/moduleroot/Rakefile.erb
Lines 69 to 71 in d05508f
There doesn't seem to be a way to trivially disable puppet-lint fail_on_warnings in the lint rake task as the default is true via https://github.com/puppetlabs/puppetlabs_spec_helper/blob/01886e8fb8c9470e74ffde39445732ce06209125/lib/puppetlabs_spec_helper/rake_tasks.rb#L156 and the template only supports setting to true. Perhaps this fragment could be changed to something like this?
lint
true
<% if @configs.include?('linter_fail_on_warnings') -%> <% if @configs['linter_fail_on_warnings'] -%> PuppetLint.configuration.fail_on_warnings = true <% else -%> PuppetLint.configuration.fail_on_warnings = false <% end -%> <% end -%>
This would also match the description of the setting:
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
pdk-templates/moduleroot/Rakefile.erb
Lines 69 to 71 in d05508f
There doesn't seem to be a way to trivially disable puppet-lint fail_on_warnings in the
lint
rake task as the default istrue
via https://github.com/puppetlabs/puppetlabs_spec_helper/blob/01886e8fb8c9470e74ffde39445732ce06209125/lib/puppetlabs_spec_helper/rake_tasks.rb#L156 and the template only supports setting totrue
. Perhaps this fragment could be changed to something like this?This would also match the description of the setting:
The text was updated successfully, but these errors were encountered: