puppet_enterprise module defines aio_agent_build and aio_agent_version fact despite aio_agent_version being a core fact

[bastelfreak]

Describe the Bug

aio_agent_version is a core fact. The puppet_enterprise module overwrites it. And it has an additional fact that provides the version, aio_agent_build. I assume aio_agent_build might be used when people have a dev version that are something like $major.$minor.$patch-$git-sha. But this is hard to figure out because the git repository is private, so I cannot do a git blame nor can I check the git history. In the past I sometimes had luck to find a jira key in the source code, but the PE project isn't accessible anymore for partners.

It looks like those two facts are redundant. I could provide a patch, but the PE license prohibits it to share code snippets. If the git repo would be accessible I could provide a PR. If the build pipelines would be accessible I could figure out if aio_agent_build is used for dev versions.

Expected Behavior

Don't overwrite core facts.

Steps to Reproduce

Install PE 2019, or 2021, or 2023, check /opt/puppetlabs/puppet/modules/puppet_enterprise/lib/facter/aio_agent_*.rb

Environment

• PE 20198.12, or 2021.7.9, or 2023.8.0,

Additional Context

I still think that it's bad that the the jira project isn't accessible anymore for partners. Also it was promised that at least certain people get access to the puppet_enterprise git repos, but after years that's still not the case. And I think that the PE license harms the development of the code base.

[bastelfreak]

support ticket 01247472