Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) change maint-mode state of status implementation to :starting #1753

Conversation

wkalt
Copy link
Contributor

@wkalt wkalt commented Nov 17, 2015

This changes our status implementation to return :starting while in maint mode,
and bumps to the status-service version that enables the change.

@kbarber kbarber added this to the 4.0.0 (master) milestone Nov 17, 2015
@puppetlabs-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/278/
Test PASSed.

@kbarber
Copy link
Contributor

kbarber commented Nov 18, 2015

How do I artificially create this maintenance mode so I can manually test? :-). Sorry, I presume this is HA stuff I'm not across :-).

Incidentally, while I was starting and just seeing what it did while I kept curling, I get an 'unknown' state: https://gist.github.com/kbarber/e36fcd54373cb8c75247. Incidentally, this is a pre-existing condition it would seem.

@wkalt
Copy link
Contributor Author

wkalt commented Nov 18, 2015

Nope, not HA stuff. The easiest thing to do is probably query

curl -X GET http://localhost:8080/status/v1/services

in a bash loop during PDB startup, and observe that you get a few "starting" statuses.

@wkalt
Copy link
Contributor Author

wkalt commented Nov 18, 2015

To your second point that's a bug with the mq-depth component. I'll add some handling there.

@kbarber
Copy link
Contributor

kbarber commented Nov 19, 2015

@wkalt okay, well in that case here are my results: https://gist.github.com/kbarber/490684628d9acb69521c

I don't see the transition, I'm guessing its hidden behind these exceptions. Notice however, there is another problem with db-spec? I think we have at least 2 cases of failure in this mechanism today it seems.

This changes our status implementation to return :starting while in maint mode,
and bumps to the status-service version that enables the change.
@wkalt wkalt force-pushed the maint/master/change-maint-mode-status-to-starting branch from 7457300 to c943e94 Compare November 23, 2015 17:37
@kbarber
Copy link
Contributor

kbarber commented Nov 23, 2015

@wkalt looks good doing manual testing now: https://gist.github.com/kbarber/9ca6f28ff1745b866a27

@puppetlabs-jenkins
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/289/
Test PASSed.

kbarber added a commit that referenced this pull request Nov 23, 2015
…atus-to-starting

(maint) change maint-mode state of status implementation to :starting
@kbarber kbarber merged commit 7323fb2 into puppetlabs:master Nov 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants