Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDB-2810) Update benchmark sample data #2099

Conversation

senior
Copy link
Contributor

@senior senior commented Oct 17, 2016

The sample data included with PuppetDB that is used whenever you invoke
the benchmark tool without a dataset had become stale. Unchanged
resources for reports, producer, catalog_uuid and code_id are recent
additions that were missing from the sample data (and from the
randomization that benchmark does). This commit adds this new data.

@puppetlabs-jenkins
Copy link
Contributor

Test PASSed

@puppetcla
Copy link

CLA signed by all contributors.

The sample data included with PuppetDB that is used whenever you invoke
the benchmark tool without a dataset had become stale. Unchanged
resources for reports, producer, catalog_uuid and code_id are recent
additions that were missing from the sample data (and from the
randomization that benchmark does). This commit adds this new data.
@senior senior force-pushed the ticket/master/pdb-2810-update-sample-benchmark-data branch from ee035ea to 5e9259b Compare October 18, 2016 15:34
@puppetlabs-jenkins
Copy link
Contributor

Test PASSed

@kbarber
Copy link
Contributor

kbarber commented Oct 24, 2016

I've looked through the data, the only comments were:

  • the containment paths for each resource are inaccurate (they don't match the resource, they are all just copied from a single example), the discussion we had around this was that it wasn't important 'yet' at least not for load testing, but might affect modelling in a UI if people want to use this data for this purpose.
  • to avoid some of that ^^ we probably want to instead persist the method we use to generate data of this nature, ie. orchestrate actual puppet generating the data somehow, so things like containment_path are always correct ... this is for later though :-).

Tested this on puppetdb, and pe-puppetdb - seems to work okay. I presume this is going to create additional load if used now in a PE environment, but this reflects reality, so its 'as it should be'.

Looks good mate, I'm +1 once the build is green.

@kbarber kbarber merged commit a5b6037 into puppetlabs:master Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants