(PDB-4275) import/export configure expiration #2870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed |
1 similar comment
|
Test PASSed |
|
Test PASSed |
|
CLA signed by all contributors. |
|
Test FAILed |
|
Test PASSed |
1 similar comment
|
Test PASSed |
|
Test PASSed |
|
Test FAILed |
1 similar comment
|
Test FAILed |
austb
reviewed
Apr 5, 2019
src/puppetlabs/puppetdb/export.clj
Outdated
| [puppetlabs.puppetdb.command :as command] | ||
| [puppetlabs.puppetdb.command.constants :as command-constants] | ||
| [puppetlabs.puppetdb.utils :as utils] | ||
| [clj-time.format :as time-fmt] | ||
| [clj-time.coerce :as time-coerce] | ||
| [puppetlabs.puppetdb.schema :as pls] | ||
| [schema.core :as s] | ||
| [puppetlabs.i18n.core :refer [trs]])) | ||
| [puppetlabs.i18n.core :refer [trs]] | ||
| [flatland.ordered.map :refer [ordered-map]])) |
There was a problem hiding this comment.
Doesn't look like this is used, and it threw a compilation error in jenkins
austb
reviewed
Apr 5, 2019
src/puppetlabs/puppetdb/nodes.clj
Outdated
| :- [configure-expiration-wireformat-schema] | ||
| [nodes :- [nodes-wireformat-schema]] | ||
| (->> nodes | ||
| (filter #(false? (:expires_facts %))) |
There was a problem hiding this comment.
false? is only false for the literal value false, since expires_facts is nil this will end up not filtering anything right?
There was a problem hiding this comment.
Suggested change
| (filter #(false? (:expires_facts %))) | |
| (filter :expires_facts_updated %)) |
|
Test PASSed |
Adds export and import of configure-expiration commands via the nodes queries. This will only export nodes that have an explicit factset expiration status set.
|
Test PASSed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds export and import of configure-expiration commands via the nodes
queries