(PDB-4579) fix connection tests #3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA signed by all contributors. |
|
Just rekicked the tests travis took a while so not sure if the failures were real |
Zak-Kent
dismissed
their stale review
changing approval because looks like the tests are failing for real
PostgreSQL JDBC driver has a bug where the isValid() call on a connection does not respect timeouts. This causes our connection pool to not detect a dead connection, which will eventually exhaust our connection pool entirely. See pgjdbc/pgjdbc#1557
|
Okay switched this up - instead of using a connection test query, this is using the same JDBC driver as 6.3.x and beyond, but the version that supports JRE 7. |
rbrw
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgreSQL JDBC driver has a bug where the isValid() call on a
connection does not respect timeouts. This causes our connection pool to
not detect a dead connection, which will eventually exhaust our
connection pool entirely. See pgjdbc/pgjdbc#1557
This fix is specific to PuppetDB 5.2.x and should not be applied to
newer branches.