Fix line endings #703
Merged
Fix line endings #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is something i'd rather see in modulesync_configs |
|
actually, i have a similar PR open in concat: puppetlabs/puppetlabs-concat#373, so... yeah. should i open a PR there with exactly the same changes? |
|
yes, please. |
|
Going to close this in lieu of doing with this modulesync PR. |
|
Changed my mind. Probably don't want to wait for us to modulesync this. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-postgresql
that referenced
this pull request
Oct 23, 2017
Fix line endings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See puppetlabs/puppetlabs-concat#80 for an explanation.
i had no issues with the .rb file, but added it as well because i guessed all shebang lines are probably broken with windows line endings.
it should also be possible to just add the files with shebang lines to the gitattributes file instead of those very inclusive filters, if you prefer that.