Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile Model Update: Years of Experience #51

Closed
CCallahanIV opened this issue Aug 8, 2018 · 4 comments
Closed

Profile Model Update: Years of Experience #51

CCallahanIV opened this issue Aug 8, 2018 · 4 comments
Assignees
@jem1031
Labels
enhancement
Milestone
MVP Phase 2

Comments

@CCallahanIV
Copy link
Collaborator

CCallahanIV commented Aug 8, 2018 •
edited by justinhernandez
Loading

Add to the profile model a single select field named 'years_industry_experience' with choices:

  • 0
  • 1 - 2
  • 3 - 7
  • 7 +

Class: Model Profile
@CCallahanIV CCallahanIV added this to the MVP Phase 2 milestone Aug 8, 2018
@jem1031
Copy link
Collaborator

jem1031 commented Aug 15, 2018

The last two choices are overlapping. Should I change it to 3-6 and 7+?

jem1031 added a commit to jem1031/mentorship-app that referenced this issue Aug 15, 2018
@jem1031
Profile Model Update: Years of Experience PuPy-Python#51
53cb095
@CCallahanIV
Copy link
Collaborator Author

@jem1031 , that's a really good point - please change the ranges as you described!

justinhernandez pushed a commit that referenced this issue Aug 22, 2018
Merge pull request #53 from jem1031/years-of-experience
f5767f7 
Profile Model Update: Years of Experience #51
@jem1031 jem1031 closed this as completed Aug 29, 2018
@tpeek
Copy link
Collaborator

tpeek commented Sep 1, 2018

I find these ranges kinda confusing. If I have 6 months of experience, I have to choose 0? If I have 2 and a half years of experience, I have to choose 1-2? Maybe we should change the options so that they all overlap, to make it clear what the ranges are:

  • 0 - 1
  • 1 - 3
  • 3 - 7
  • 7 +

@jem1031 jem1031 reopened this Sep 5, 2018
@jem1031
Copy link
Collaborator

jem1031 commented Sep 5, 2018

This makes sense to me. See PR #85

@jem1031 jem1031 closed this as completed Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jem1031 jem1031

Labels
enhancement
Projects
None yet
Milestone
MVP Phase 2
Development

No branches or pull requests
3 participants
@tpeek @jem1031 @CCallahanIV