Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Flags for PROS 4 Beta Templates #256

Merged
merged 82 commits into from
Apr 18, 2023
Merged

Conversation

omegaStag
Copy link
Contributor

@omegaStag omegaStag commented Dec 27, 2022

Summary:

Adds a beta depot to the remote depots (currently only contains a 3.7.3 kernel template labeled as 4.0.0), adds --pros-4 flags for conductor commands to use the beta depot

Motivation:

For PROS 4 beta testing

References (optional):

Contains changes made in PR #253 and PR #251 and closes their respective issues, #243, #241

Test Plan:

  • Making project with --pros-4 should use beta depot
  • Upgrading with pros c upgrade --pros-4 on a PROS 3 project should have a warning
  • Downgrading with pros c apply-template kernel@3.x.x on a PROS 4 project should have a warning
  • pros c q --pros-4 should list beta templates too

@ayushuk ayushuk added the on hold This may be revisited in the future label Jan 13, 2023
@ayushuk
Copy link
Member

ayushuk commented Jan 13, 2023

Will be revisited when the pros 4 is up on the depot. Was tested with dummy pros 3 template with adjusted metadata.

Copy link
Member

@WillXuCodes WillXuCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall functionality is good, just needs one minor naming change.

pros/conductor/conductor.py Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discard Changes

Copy link
Member

@kunwarsahni01 kunwarsahni01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIWB

@kunwarsahni01 kunwarsahni01 merged commit 5b818c5 into develop Apr 18, 2023
@kunwarsahni01 kunwarsahni01 mentioned this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants