-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Flags for PROS 4 Beta Templates #256
Conversation
* Run make clean after uninstall temp * Add flag
Will be revisited when the pros 4 is up on the depot. Was tested with dummy pros 3 template with adjusted metadata. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall functionality is good, just needs one minor naming change.
…li into feature/pros-4-beta
pros/cli/terminal.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discard Changes
Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com>
* Run make clean after uninstall temp * Add flag
…li into feature/pros-4-beta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIWB
Summary:
Adds a beta depot to the remote depots (currently only contains a 3.7.3 kernel template labeled as 4.0.0), adds
--pros-4
flags for conductor commands to use the beta depotMotivation:
For PROS 4 beta testing
References (optional):
Contains changes made in PR #253 and PR #251 and closes their respective issues, #243, #241
Test Plan:
--pros-4
should use beta depotpros c upgrade --pros-4
on a PROS 3 project should have a warningpros c apply-template kernel@3.x.x
on a PROS 4 project should have a warningpros c q --pros-4
should list beta templates too