✨Run make clean after uninstall template #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing |
omegaStag
changed the title
|
Tested and functioned as expected:
|
ayushuk
approved these changes
Nov 8, 2022
This was referenced Nov 12, 2022
Merged
kunwarsahni01
added a commit
that referenced
this pull request
Nov 14, 2022
* 🐛 emit correct compiler for C files when generating CDB (#188) * Update Azure Pipelines with new self hosted M1 Mac (#189) * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Fixes 'make.exe.exe' typo. Adds disable sentry prompt option for VSCode. (#190) * Fixes 'make.exe.exe' typo. Adds disable sentry prompt option for VSCode. * Fix sentry-off flag * change sentry-off to no-sentry * Update Version (#186) (#191) * ✨Add Analytics (#193) * Fix and move no-sentry to default options. Setup framework for analytics * Fix some things. --toggle-analytics works * Analytics should be working. Need to figure out which commands matter * Make use-analytics a choice not a toggle * Show no-analytics flag feedback so user knows it works * Analytics appear to be working! * Reset uid to None * Compress code a bit * Remove interactive command analytics. Fix info-project typo * Move GA config to cli.pros. Fixes --use-analytics * ✨More Upload Options (#194) * Start of more upload options * Adds project icon, name, and description. Use name/description="string" * pros v5 rm-program command * rm program literals * Remove extra print messages. Kernel version = None when no project * Update Version (#186) (#195) * Add __init__ file so ga is considered a module (#206) * Fix issue with programs uploading segfaulting/NACKing/doing nothing (#207) * ✨Set team number and robot name (#210) * Adds kv_read and kv_write functions (UNTESTED) to V5Device class * Add commands to read and set kernel variables * Add descriptions to set_variable and read_variable commands * Finish reading kernel variables. Use None for unknown rx length * Trim kernel variable value and ensure null terminated. * Move rv and sv to v5 commands * Working set command. Maximum lengths based on brain's screen space * get and set aliases * Add m as an alias for pros make. (#204) * Cleaned Up CI (#213) * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Revert "✨Set team number and robot name (#210)" (#214) This reverts commit 62ee4b8. * ✨Set team number and robot name (#219) * old code (not working) * use correct txrx function * return set value * ✨Terminal file output (#220) * Added file redirect click.option to terminal.py * Got rid of indentation error * Added code for output * Redirects standard output stream to file * Outputs to both terminal and file * Modified imported modules * Added line at end * changes on windows * Update pros/cli/terminal.py for terminal file output Co-authored-by: Will Xu <54247087+WillXuCodes@users.noreply.github.com> * Removed ident error Co-authored-by: BennyBot <48661356+BennyBot@users.noreply.github.com> Co-authored-by: Will Xu <xu1321@purdue.edu> Co-authored-by: Benjamin Davis <davi1561@purdue.edu> Co-authored-by: Will Xu <54247087+WillXuCodes@users.noreply.github.com> Co-authored-by: BennyBot <48661356+BennyBot@users.noreply.github.com> * Fix typo in comment * add FEATURE_REQUEST.md (#230) * ✨Move Issue Template Files (#231) * Move Issue Template Files * Update BUG_REPORT.md * Create main.yml * Update main.yml * Add pyinstaller requirement * Add .spec file * Update main.yml * add universal2 arch * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * attempt fake version number * Update main.yml * Update main.yml * Update main.yml * version.py exception * Update main.yml * Try adding --always and stderr * remove --always * fetch tags to prevent name error? * Add Fetch Depth * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update requirements.txt * Remove older ci/cd files * Move to new build constants system * Basic Import structure for pyinstaller * Move back to spec file * Install wheel first * Correct constant writing * Remove old Build Constants * Add wheel building * Different Name for Wheel Artifact * Typo * Codeql Analysis * Only on dev/master for code scan * 🔖 Release 3.3.3 (#215) * 🐛 emit correct compiler for C files when generating CDB (#188) * Update Azure Pipelines with new self hosted M1 Mac (#189) * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Fixes 'make.exe.exe' typo. Adds disable sentry prompt option for VSCode. (#190) * Fixes 'make.exe.exe' typo. Adds disable sentry prompt option for VSCode. * Fix sentry-off flag * change sentry-off to no-sentry * Update Version (#186) (#191) * ✨Add Analytics (#193) * Fix and move no-sentry to default options. Setup framework for analytics * Fix some things. --toggle-analytics works * Analytics should be working. Need to figure out which commands matter * Make use-analytics a choice not a toggle * Show no-analytics flag feedback so user knows it works * Analytics appear to be working! * Reset uid to None * Compress code a bit * Remove interactive command analytics. Fix info-project typo * Move GA config to cli.pros. Fixes --use-analytics * ✨More Upload Options (#194) * Start of more upload options * Adds project icon, name, and description. Use name/description="string" * pros v5 rm-program command * rm program literals * Remove extra print messages. Kernel version = None when no project * Update Version (#186) (#195) * Add __init__ file so ga is considered a module (#206) * Fix issue with programs uploading segfaulting/NACKing/doing nothing (#207) * ✨Set team number and robot name (#210) * Adds kv_read and kv_write functions (UNTESTED) to V5Device class * Add commands to read and set kernel variables * Add descriptions to set_variable and read_variable commands * Finish reading kernel variables. Use None for unknown rx length * Trim kernel variable value and ensure null terminated. * Move rv and sv to v5 commands * Working set command. Maximum lengths based on brain's screen space * get and set aliases * Add m as an alias for pros make. (#204) * Cleaned Up CI (#213) * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Revert "✨Set team number and robot name (#210)" (#214) This reverts commit 62ee4b8. * Update Version to 3.3.3 * Update Version to 3.3.3 * Revert kernel variable read/set Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com> Co-authored-by: Alex Brooke <akb.sbc@gmail.com> * ✨Set team number and robot name (#219) * old code (not working) * use correct txrx function * return set value * ✨Terminal file output (#220) * Added file redirect click.option to terminal.py * Got rid of indentation error * Added code for output * Redirects standard output stream to file * Outputs to both terminal and file * Modified imported modules * Added line at end * changes on windows * Update pros/cli/terminal.py for terminal file output Co-authored-by: Will Xu <54247087+WillXuCodes@users.noreply.github.com> * Removed ident error Co-authored-by: BennyBot <48661356+BennyBot@users.noreply.github.com> Co-authored-by: Will Xu <xu1321@purdue.edu> Co-authored-by: Benjamin Davis <davi1561@purdue.edu> Co-authored-by: Will Xu <54247087+WillXuCodes@users.noreply.github.com> Co-authored-by: BennyBot <48661356+BennyBot@users.noreply.github.com> * Fix typo in comment * add FEATURE_REQUEST.md (#230) * ✨Move Issue Template Files (#231) * Move Issue Template Files * Update BUG_REPORT.md * ✨ Version Display On Error * Update main.yml * Update main.yml * Revert "Merge branch 'develop' of github.com:purduesigbots/pros-cli into develop" This reverts commit a3de138, reversing changes made to d953b0d. * Revert "Revert "Merge branch 'develop' of github.com:purduesigbots/pros-cli into develop"" This reverts commit 0929e41. * ✨ Run make clean after uninstall template (#244) * Run make clean after uninstall temp * Add flag * Update version to 3.4.1 Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com> Co-authored-by: Alex Brooke <akb.sbc@gmail.com> Co-authored-by: BennyBot <48661356+BennyBot@users.noreply.github.com> Co-authored-by: Benjamin Davis <davi1561@purdue.edu> Co-authored-by: sharmaneha03 <98361515+sharmaneha03@users.noreply.github.com> Co-authored-by: Will Xu <xu1321@purdue.edu> Co-authored-by: Will Xu <54247087+WillXuCodes@users.noreply.github.com> Co-authored-by: niu <57331513+omegaStag@users.noreply.github.com> Co-authored-by: Liam Teale <111480281+SizzinSeal@users.noreply.github.com> Co-authored-by: AlexHunton2 <alexhunton02@gmail.com> Co-authored-by: omegaStag <kathyniu2003@gmail.com>
omegaStag
added a commit
that referenced
this pull request
Dec 27, 2022
* Run make clean after uninstall temp * Add flag
omegaStag
added a commit
that referenced
this pull request
Apr 17, 2023
* Run make clean after uninstall temp * Add flag
kunwarsahni01
added a commit
that referenced
this pull request
Apr 18, 2023
* Initial commit for prompt * Created flag for kernel templates * Added warning code to apply_template * Removed accidental extra lines * Removed accidental whitespace * ✨ Run make clean after uninstall template (#244) * Run make clean after uninstall temp * Add flag * Update Version to 3.4.0 * ✨Added message for terminal connection (#254) * Add beta depot and flag to upgrade * Only use beta depot if specified * Change --pros-4 to --beta * Add ReleaseChannel enum to conductor.py * Fix up some lines * Change the url to reflect json moved in repo * Change name of beta depot * CHange beta depot name too * Fixed making PROS 4 when trying to make PROS 3 project * Change beta enum to bool * WIP fix * Remove debug prints * Add beta_local_templates category * Fix conductor.config issue * Resolve conflict * Display all templates with --beta in pros c q * Add beta flag * Uninstall charset_normalizer * Allow uninstalling invalid templates * Initial commit for prompt * Added warning code to apply_template * Removed accidental extra lines * Removed accidental whitespace * Created flag for kernel templates * Add beta depot and flag to upgrade * Only use beta depot if specified * Change --pros-4 to --beta * Add ReleaseChannel enum to conductor.py * Fix up some lines * Change the url to reflect json moved in repo * Change name of beta depot * CHange beta depot name too * Fixed making PROS 4 when trying to make PROS 3 project * Change beta enum to bool * WIP fix * Fix conductor.config issue * Remove debug prints * Add beta_local_templates category * Display all templates with --beta in pros c q * Add beta flag * Allow uninstalling invalid templates * Change url * Fix url * Temp fix * Update pros/cli/conductor.py Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com> * Initial commit for prompt * Added warning code to apply_template * Removed accidental extra lines * Removed accidental whitespace * ✨ Run make clean after uninstall template (#244) * Run make clean after uninstall temp * Add flag * ✨Added message for terminal connection (#254) * Created flag for kernel templates * Add beta depot and flag to upgrade * Change --pros-4 to --beta * Add ReleaseChannel enum to conductor.py * Fix up some lines * Fixed making PROS 4 when trying to make PROS 3 project * Change beta enum to bool * WIP fix * Fix conductor.config issue * Remove debug prints * Allow uninstalling invalid templates * Change url * Fix url * Random line left lol * Fixing * Remove irrelevant change * Put this back * Add liblvgl message --------- Co-authored-by: Andrew Chen <chen4192@purdue.edu> Co-authored-by: Christopher Tan <72955765+Christopher-Tan@users.noreply.github.com> Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com> Co-authored-by: ayushuk <ayushshukla30339@gmail.com> Co-authored-by: Ayush Shukla <71904196+ayushuk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Runs make clean after removing a template from a project, adds a flag to control this behavior (on by default)
Motivation:
If a user removes a template it should make clean automatically on the project
References (optional):
Closes #234
Test Plan:
Create project, uninstall okapilib and see that it makes clean after removing
Install okapilib again, uninstall it with flag to make it not run make clean