Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰Fix issue with invalid directory name check #282

Merged
merged 2 commits into from
May 15, 2023

Conversation

ghost
Copy link

@ghost ghost commented May 12, 2023

Summary:

Removed "", "/", and ":" characters from check for invalid directory name when creating a project.

Motivation:

Preventing these characters from being used caused issues with using absolute file paths when creating a project.

References (optional):

Issue #278 is still unresolved

Test Plan:

  • Attempt to create a project using an absolute file path (that includes all 3 characters)
    image

@ayushuk
Copy link
Member

ayushuk commented May 13, 2023

The backslash is still in the check, how were you able to create a project with it in the name? Also we should probably remove it anyways if people want to create project on windows and it does trigger.

Copy link
Member

@ayushuk ayushuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the backslash from the check

@ghost
Copy link
Author

ghost commented May 13, 2023

I made that mistake at first too, '\'' is the single quote character (the backslash is the escape character in this case)

Copy link
Member

@ayushuk ayushuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayushuk ayushuk merged commit feb5a48 into develop May 15, 2023
10 checks passed
@ayushuk ayushuk deleted the hotfix/invalid-directory-name branch May 15, 2023 02:06
This was referenced May 15, 2023
@stualden
Copy link

I ran into this problem yesterday (it gagged on the colon, which is a problem if you're working with Windows!). Will this fix make it into the VSCode extension installation soon? Sorry for the newbie question - I started to learn PROS just yesterday and this was a big roadblock.

@ayushuk
Copy link
Member

ayushuk commented Jun 14, 2023

Hello, thanks for trying out PROS! The bugfix is merged and we are in the process of making the release but are running into some issues. For now, you can use the pros terminal to make new projects using pros c n [project directory]. Sorry about the inconvenience.

@stualden
Copy link

Thank you for all your great work on this project! And thanks for that tip - so long as [project directory] contains no colon or backslash(es), it appears to work just fine, as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants