Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔖 Release 3.4.3 #284

Merged
merged 3 commits into from
May 19, 2023
Merged

🔖 Release 3.4.3 #284

merged 3 commits into from
May 19, 2023

Conversation

ayushuk
Copy link
Member

@ayushuk ayushuk commented May 15, 2023

This release is a hotfix to an issue with users not being able to create a project with the PROS VSC extension due to the CLI project name check.

kunwarsahni01 and others added 3 commits May 11, 2023 20:22
* Update main.yml

* Try new version of python

* Maybe this will work?

* We try again

* Make the uninstall work

* Work
* Removed check for "\", "/", and ":" in directory name

* Corrected accidental removal of wrong character
@ayushuk ayushuk marked this pull request as ready for review May 15, 2023 02:30
Copy link
Contributor

@noam987 noam987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as upgrading the python version in the CI doesn't break anything, LGTM

.github/workflows/main.yml Show resolved Hide resolved
version Show resolved Hide resolved
win_version Show resolved Hide resolved
pip_version Show resolved Hide resolved
@ayushuk ayushuk requested a review from WillXuCodes May 18, 2023 04:30
Copy link
Member

@WillXuCodes WillXuCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure not to squash merge as per gitflow

@ayushuk ayushuk merged commit 98230de into master May 19, 2023
@ayushuk ayushuk deleted the release/3.4.3 branch May 19, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants