-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid units should have box-sizing: border-box by default. #20
Comments
Since By default, grid units don't have any margin/padding. If you want to add these, put them in a child container. there is no need for that |
+1 for looking into to this. @msweeney it would be great to get your thoughts on this too. |
I'm assuming the rationale for overriding default Pros:
Cons:
I'd prefer we didn't have an opinion either way, and just use the default, assuming users can customize as needed. |
Yeah, good idea, that's seems like the smart thing to do. @tilomitra we could handle this through documentation, e.g. on the site's grids page we could so an example that uses |
@ericf @msweeney I'm okay with this. Closing this out and adding it as a documentation issue on pure-site: |
We should look at moving to
box-sizing: border-box
by default for all containers.The text was updated successfully, but these errors were encountered: