-
Notifications
You must be signed in to change notification settings - Fork 242
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
first cut at new "list" box like number or symbol but for multiple
atoms. Double-clicking in run mode activates text editing. (Single clicks should work as before). At least one remaining graphics bug still needs sorting out.
- Loading branch information
1 parent
248608d
commit cf44c8b
Showing
14 changed files
with
723 additions
and
430 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
cf44c8b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice.
some remarks:
80
; as of increase ATOMBUFSIZE to 200, max symbol atom width to 120 #1260 there is demand to raise that limit0
no longer gives a varsized box, but instead it seems that you get a display-only box (not only for listboxes, but also for numberboxes!). this is probably intended - but it is likely to break patches. at least i have often used a width=0 to get a small numberbox that allows me to type arbitrary values without getting the dreaded...
it also is different from what is documented in the
[pd properties]
subpatch)cf44c8b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the 0-width thing is probably a bug - I intended for it to act the way it always has. I never use that but will check it out now :)
Meanwhile, I'm not sure what the thing should do when clicking outside the box after typing. I originally had it jump back to its previous contents but the it's enraging to type out a long list and then just lose it. Perhaps some other behavior would be better if someone could think of it.
cf44c8b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that it is also true for the new version of the symbolbox.
cf44c8b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not only weird, but it makes it impossible for listbox and symbol not to repeat their last input after switching back focus to them. Consider this scenario:
cf44c8b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how the proposed behavior is helpful. Consider this scenario:
Before this change, symbolbox and numberbox would simply loose their incomplete content when clicking into empty patcher space. The likeliness of losing a tedious edit is the same. However, I consider outputting an incomplete content to be worse than just not outputting at all. The likeliness of triggering something unwanted is surely higher.
My user experience taught me that I can continue editing where I left off before. I'd prefer if symbolbox, numberbox, listbox neither output nor clear, but simply keep their content until I hit .
cf44c8b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the box width of symbolbox and numberbox are increased by 2 pixels with this change:
It somewhat makes sense to have them use the same size as object boxes, but this change breaks patches that fit number- and symbolboxes into GOP-areas.
cf44c8b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I think I need to rethink the click-out-of-box behavior. Meanwhile I've fixed the 2-pixel width thing locally, will push it to github soon.