canvas zoom and scroll with mousewheel #1659

Ant1r · 2022-05-01T14:04:21Z

Zoom and scroll with the mouse wheel, like most modern software.

The code is adapted from https://wiki.tcl-lang.org/page/Canvas+zooming+using+mousewheel.
It will also allow to clean up the GUI C code from every IEMGUI_ZOOM() occurrences and logic ;-)

Note: the current zoom factor could be reported to the Pd-core side, in order to be saved to file.

Ant1r · 2022-05-02T07:34:22Z

Trying to update the line-width of lines and rectangles:

umlaeute · 2022-05-02T11:56:14Z

oh shit.

Spacechild1 · 2022-05-02T20:59:41Z

That's just awesome! Pd badly needs a proper zoom function...

Ant1r · 2022-05-13T14:15:26Z

"Almost" good here!
At least edition is now possible in a zoomed canvas.
Still some bugs, with "undo" for example.
Scrolling to the zooming center still to be done too.

Ant1r · 2022-05-14T15:34:30Z

I think it's about ready.
I've fixed some bugs, and added scrolling with mouse button 2 (scrollwheel button). Very pleasant...
Please test!

tcl/pd_canvaszoom.tcl

umlaeute · 2022-05-30T15:42:50Z

the current zoom factor should be reported to the Pd-core side, in order to be saved to file.

i honestly don't think so.
this could be saved entirely on the GUI side via ::pd_guiprefs::write (resp ::pd_guiprefs::read)

umlaeute · 2022-05-30T15:55:35Z

i wonder whether the internal zoom-state should (also) be kept as a "step" value, so it's easier to reset to zoom=0 (and when saving the zoom-amount to a preferences file, we can store simple integers and don't have to worry about precision)

this would of course totally break if the zoom-factor was changeable.

Ant1r · 2022-05-30T17:13:30Z

this could be saved entirely on the GUI side via ::pd_guiprefs::write (resp ::pd_guiprefs::read)

I was thinking that the zoom factor could be saved per-patch, I mean both zoom factor and scrolling position can be seen as part of the final presentation of the patch to the user.

i wonder whether the internal zoom-state should (also) be kept as a "step" value

Maybe we could store something like a fractional log factor? e.g zommfactor = pow(10, zoomsteps/100) so:

-30 -> 1/2
 0  -> 1 
 30 -> 2
100 -> 10

etc... ?

Ant1r · 2022-05-30T20:31:54Z

Actually zoom factor = pow(2, steps/100) is better in order to include exact powers of 2...

umlaeute · 2022-05-30T21:04:06Z

yes, sthg like that.

I was thinking that the zoom factor could be saved per-patch

hmm, interesting idea.

what i do love about this entire PR, is that it it's totally unrelated to Pd-core, and just does all the magic on the GUI side.
the only changes on the C side would be to get rid of the entire zoom-goo there.

Ant1r · 2022-05-30T22:19:59Z

Yeah, thanks, that's what I like too. I'm dreaming of a world where Pd doesn't even know how do the objects look like on the patch...

If I had more time I'd love to try recoding my entire new knob in TCL, as an exercise. I wonder what change in the core would be needed, if any.
((edit) I meant rewriting in TCL the purely GUI part of the knob)

Ant1r · 2022-09-27T09:55:39Z

internal zoom-state should (also) be kept as a "step" value

done. Now the depth is expressed in steps, and the actual depth is pow(2, steps / 100).
zsteps is kept within the [-400 , 400] range, so zdepth remains within [1/16 , 16].

Ant1r · 2023-04-09T10:36:36Z

This PR has been brought up to date.

I would appreciate it being tested in a variety of circumstances, so that we can insist to have it included.
My own tests show no obvious problem.

Ant1r · 2023-06-21T17:24:41Z

This PR has been updated to latest master, and debugged for MacOS and Windows.

Spacechild1 · 2023-06-29T10:21:14Z

I already gave many thumbs up, but I haven't come around to actually test it yet. I will put this on my list and then lobby relentlessly to have this included in Pd 0.55 :)

pingarelho · 2023-12-21T17:11:40Z

Firstly, thank you for this PR, I have been using it extensively for the past month.

I noticed that when zooming in and out, and then going to the properties screen and clicking ok, the label and the value of a [nbx], for instance, can change a bit. Video below for reference.

zoom_pr.mp4

Ant1r · 2023-12-22T13:58:51Z

Thanks for the feedback, I'll check that as soon as I can (which won't be for a good week).

…ead of global

…tting zoom if needed

simplifying the MouseWheel bindings (and prepare for Ctrl-+ resp Ctrl--)

…patch

…oo wide

…ntries

- the "Zoom New Windows" setting is now saved to {pd_guiprefs}/default_zoom.conf - the old .pdsettings::zoom is ignored - LATER: allow other default_zoom values than 0(100%) or 100(200%)

better keeping immobile the content under the mouse

(and give up trying to do it on scrolling, no working solution was found)

(except for text items and rectangular selection outline)

Ant1r · 2024-03-14T21:46:23Z

updated and rebased.

sebshader · 2024-03-25T20:20:14Z

wouldn't it be more complete/consistent if the c-side zoom logic were taken out as well?

Ant1r · 2024-03-25T21:18:15Z

Of course I'm all for doing it, but let's see if it's worth the effort...

Ant1r · 2024-04-15T11:31:59Z

@millerpuckette have you had a chance to test this one?

Ant1r force-pushed the feature/mousewheel-zoom branch from 11d9f63 to 6113a3a Compare May 13, 2022 14:08

Ant1r marked this pull request as ready for review May 14, 2022 15:34

Ant1r changed the title ~~[feature] POC control-mousewheel canvas zoom~~ [feature] canvas zoom and scroll with mousewheel May 14, 2022

umlaeute reviewed May 14, 2022

View reviewed changes

tcl/pd_canvaszoom.tcl Outdated Show resolved Hide resolved

umlaeute reviewed May 14, 2022

View reviewed changes

tcl/pd_canvaszoom.tcl Outdated Show resolved Hide resolved

Ant1r mentioned this pull request Jun 7, 2022

[image] should follow zoom MetaluNet/moonlib#18

Open

umlaeute mentioned this pull request Aug 29, 2022

Offer more than two zoom settings #1726

Open

umlaeute linked an issue Aug 29, 2022 that may be closed by this pull request

Offer more than two zoom settings #1726

Open

umlaeute added the feature suggestion for an enhancement label Sep 5, 2022

Spacechild1 changed the title ~~[feature] canvas zoom and scroll with mousewheel~~ canvas zoom and scroll with mousewheel Sep 14, 2022

Ant1r mentioned this pull request Jun 29, 2023

GUI scaling issues #1725

Open

60-hz mentioned this pull request Dec 21, 2023

include Snap to Grid for pd-next sebshader/pdnext#26

Open

sebshader mentioned this pull request Dec 22, 2023

include incremental zoom for pd-next sebshader/pdnext#27

Open

Ant1r and others added 24 commits March 14, 2024 22:12

[zoom] use namespace variables for storing zdepth and oldzdepth, inst…

5d6aab0

…ead of global

[zoom] split ::pd_canvaszoom::setzdepth from "zoom" proc, to allow se…

3864b4d

…tting zoom if needed

[zoom] bring every proc to the pd_canvaszoom namespace

66cac84

[zoom] stepzoom proc: stepwise zoom (rather than factorwise)

1fa57df

simplifying the MouseWheel bindings (and prepare for Ctrl-+ resp Ctrl--)

[zoom] fixes for latest pd changes

d0264ef

[zoom] prevent Mouse button 2 (scrollwheel click) from acting on the …

1ee25cb

…patch

[zoom] better font scaling, making sure that the scaled text is not t…

9517532

…oo wide

[zoom] use integer representation of the zoom depth

999c3d1

[zoom] clip zoom depth to [1/16 , 16]

23d13c4

[zoom] reuse Ctrl+ and Ctrl- shortcuts and reassign Edit/Zoom* menu e…

35fb8d0

…ntries

[zoom] redirect the "Zoom New Windows" system

c01e5c5

- the "Zoom New Windows" setting is now saved to {pd_guiprefs}/default_zoom.conf - the old .pdsettings::zoom is ignored - LATER: allow other default_zoom values than 0(100%) or 100(200%)

[zoom] bugfix in ::pd_canvaszoom::scalefont

fc8f23e

[zoom] fix the scroll_point_to function

c54313c

better keeping immobile the content under the mouse

[zoom] temporarily display the current zoom factor when changed

80c4ce7

[zoom] improve responsivity

da52fb7

[zoom] improve zooming responsiveness

fcb57c1

(and give up trying to do it on scrolling, no working solution was found)

[zoom] prefer north-west for z-depth toast display

305723f

[zoom] don't use 'string cat' because incompatible with tk<8.6.2

dca0656

[zoom] remove leftovers

344d88a

[zoom] update mousewheel bindings for windows and macos

55ffe54

[zoom] use Button-3 for scrolling on MacOS

278d862

[zoom] fix syncing the state of 'Zoom new windows' checkbox

8a0d559

[zoom] store the original font size as soon as the item is configured

59652d2

[zoom] default item linewidth to 1.0 at creation time

9b0107e

(except for text items and rectangular selection outline)

Ant1r force-pushed the feature/mousewheel-zoom branch from 4643f8f to 9b0107e Compare March 14, 2024 21:43

[zoom] speed up the creation of non-zoomed windows

3cad579

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

canvas zoom and scroll with mousewheel #1659

canvas zoom and scroll with mousewheel #1659

Ant1r commented May 1, 2022 •

edited

Ant1r commented May 2, 2022

umlaeute commented May 2, 2022

Spacechild1 commented May 2, 2022

Ant1r commented May 13, 2022

Ant1r commented May 14, 2022

umlaeute commented May 30, 2022 •

edited

umlaeute commented May 30, 2022

Ant1r commented May 30, 2022

Ant1r commented May 30, 2022

umlaeute commented May 30, 2022

Ant1r commented May 30, 2022 •

edited

Ant1r commented Sep 27, 2022 •

edited

Ant1r commented Apr 9, 2023

Ant1r commented Jun 21, 2023

Spacechild1 commented Jun 29, 2023

pingarelho commented Dec 21, 2023 •

edited

Ant1r commented Dec 22, 2023

Ant1r commented Mar 14, 2024

sebshader commented Mar 25, 2024

Ant1r commented Mar 25, 2024

Ant1r commented Apr 15, 2024

canvas zoom and scroll with mousewheel #1659

Are you sure you want to change the base?

canvas zoom and scroll with mousewheel #1659

Conversation

Ant1r commented May 1, 2022 • edited

Ant1r commented May 2, 2022

umlaeute commented May 2, 2022

Spacechild1 commented May 2, 2022

Ant1r commented May 13, 2022

Ant1r commented May 14, 2022

umlaeute commented May 30, 2022 • edited

umlaeute commented May 30, 2022

Ant1r commented May 30, 2022

Ant1r commented May 30, 2022

umlaeute commented May 30, 2022

Ant1r commented May 30, 2022 • edited

Ant1r commented Sep 27, 2022 • edited

Ant1r commented Apr 9, 2023

Ant1r commented Jun 21, 2023

Spacechild1 commented Jun 29, 2023

pingarelho commented Dec 21, 2023 • edited

Ant1r commented Dec 22, 2023

Ant1r commented Mar 14, 2024

sebshader commented Mar 25, 2024

Ant1r commented Mar 25, 2024

Ant1r commented Apr 15, 2024

Ant1r commented May 1, 2022 •

edited

umlaeute commented May 30, 2022 •

edited

Ant1r commented May 30, 2022 •

edited

Ant1r commented Sep 27, 2022 •

edited

pingarelho commented Dec 21, 2023 •

edited