Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disallow creating an object with the name "anything" #381

Closed
wants to merge 1 commit into from

Conversation

Spacechild1
Copy link
Contributor

...because this would eventually override pd_objectmakers's anything method, essentially breaking the abstraction/external loading mechanism.
fixes #372

…ld eventually override pd_objectmakers's anything method, essentially breaking the abstraction/external loading mechanism.
@millerpuckette
Copy link
Contributor

This is an interesting way an extern could bring Pd to its knees - but it will always be possible
for unfortunatelt written externs to crash Pd so I think this doesn't need to be enshrined in code -
perhaps it's worth a warning in the externs howto instead.

@Spacechild1
Copy link
Contributor Author

but it's quite easy for users to name one of their abstractions "anything", as this user did: #372
without knowing the internals of Pd, there's no way of knowing that this is not allowed...
Won't it be better to have this fixed?

@millerpuckette
Copy link
Contributor

Ah, right, I hadn't caught on that even making an 'anything' abstraction would add a
new method. I wonder what other side effects we can expect from that... anyhow, I'm convinced
and have adopted this.

@Spacechild1 Spacechild1 closed this Aug 5, 2018
@Spacechild1 Spacechild1 deleted the anything_bug branch September 9, 2018 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abstractions named "anything"
2 participants