allow [nbx] to show 'nan' and 'inf'/"-inf" and don't clip input #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this partially deals with #629
porres
changed the title
|
the test
|
|
for the nan, I used a 'isnan' check - gatom does that too. What I didn't do is have a check if the last value was also a nan, but maybe Miller can do that in the way it's considered best? I wasn't sure. refarding inf/-inf, I also got inspired on how gatom handles this. |
porres
changed the title
umlaeute
added
severity:feature
|
I see this marked as a "feature" and I'm not sure about that. At least not being able to print nans is clearly a bug to me. The other issues (printing 'inf' and not clip values) are just a fix for a consistent behaviour for the iemguis and also atom float box |
This was referenced May 5, 2020
|
I guess I also need to create a compatibility flag for the new unclipped behavior, see #633 (comment) |
|
closing in favor of #999 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the first 2 commits closes #629
the 3rd commit closes #633