Fix empty defaults for base colors #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andreiborisov Is there anything you wanted to add to this PR? I added tests for the feature, but the CI is failing for unrelated reason (fisher API changed) |
|
No, this should do the trick, but it’s a little bit overzealous and I don’t know if the issue still persists. |
edouard-lopez
force-pushed
the
fix-empty-colors
branch
from
bee7778
to
06231d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes initialization produces empty values when upgrading from the old version. This PR adds an additional check to make sure the user won't have empty colors.