Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refrain from printing container string matches #283

Conversation

erik-inkapool
Copy link

_pure_is_inside_container prints all matches. Using test -n will just evaluate to true/false depending on if matches found, which seems like the intention of this tests. This fixes #166 for me, but I'm not sure if it's the only fix required to close that issue.

@edouard-lopez
Copy link
Member

Thanks @erik-inkapool, I will have a look at this

@edouard-lopez
Copy link
Member

Hello @erik-inkapool,
Thank you for your patience, I'm resuming my work on pure. I will first focus on fixing the tests, before merging the existing request that touch to the codebase, to ensure we have no regression.

@edouard-lopez
Copy link
Member

edouard-lopez commented Jan 31, 2023

@erik-inkapool I fixed issues related to container detection in https://github.com/pure-fish/pure/releases/tag/v4.2.2, https://github.com/pure-fish/pure/releases/tag/v4.2.3.
Is this issue still happening with version ≥4.4.0? If so, could you provide more context with:

<!--
Please provide following information to help us debug your issue faster.
-->

## Env

**Pure**

    echo $pure_version

**Fish**

    fish --version

**OS/distribution**

    lsb_release -a

Also share the output of your prompt if that's relevant.

@edouard-lopez edouard-lopez force-pushed the refrain-from-printing-container-string-matches branch from 153d2f4 to 9b5a46b Compare August 21, 2023 08:26
@edouard-lopez edouard-lopez merged commit 5a46923 into pure-fish:master Aug 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The path part doesn't show
2 participants