Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to fishtape 3 #275

Merged
merged 31 commits into from
Oct 6, 2022
Merged

migrate to fishtape 3 #275

merged 31 commits into from
Oct 6, 2022

Conversation

edouard-lopez
Copy link
Member

@jorgebucaran wanna try it?

⚠️ still a work in progress and plenty of failing tests I stop in the middle :/

  • restrict _purge_configs & _disable_colors execution to test container
  • add _pure_is_inside_container
  • refactor methods into _pure_user_at_host
  • add v3->v4 migration script to update variables
  • bump version 4.0.0
  • show user@host when running in a container
  • bump version 4.1.0
  • quote test arguments
  • remove import for version-compare in test
  • correct typo
  • use (status filename) instead of $current_filename
  • Use (dirname (status filename)) instead of $current_dirname (needs Fish >=3.2).
  • replace @mesg by @echo
  • explicit call to setup and teardown

@jorgebucaran jorgebucaran self-requested a review February 18, 2021 03:22


function setup
_purge_configs
_disable_colors
set --universal pure_symbol_prompt '❯'
set --universal pure_symbol_reverse_prompt '❮'
end
end; setup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are not using setup anywhere else, you might as well remove the setup function and just leave the code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to keep the function, it helps explicit what the code does

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd agree if we were using the function more than once in the same file, but we are not.

@edouard-lopez edouard-lopez force-pushed the migrate-to-fishtape-3 branch 15 times, most recently from 4637c50 to e8e81a2 Compare October 5, 2022 11:00
@edouard-lopez edouard-lopez marked this pull request as ready for review October 6, 2022 10:10
@edouard-lopez
Copy link
Member Author

/close #272

@edouard-lopez edouard-lopez merged commit c11e27a into master Oct 6, 2022
@edouard-lopez edouard-lopez deleted the migrate-to-fishtape-3 branch October 6, 2022 10:21
edouard-lopez added a commit that referenced this pull request Oct 6, 2022
edouard-lopez added a commit that referenced this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants