-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to fishtape 3 #275
Conversation
|
||
|
||
function setup | ||
_purge_configs | ||
_disable_colors | ||
set --universal pure_symbol_prompt '❯' | ||
set --universal pure_symbol_reverse_prompt '❮' | ||
end | ||
end; setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are not using setup
anywhere else, you might as well remove the setup
function and just leave the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to keep the function, it helps explicit what the code does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd agree if we were using the function more than once in the same file, but we are not.
5628181
to
e0460ba
Compare
024c65a
to
c63f63a
Compare
change permissions
4637c50
to
e8e81a2
Compare
e8e81a2
to
29e697e
Compare
7c25c70
to
1302f64
Compare
/close #272 |
@jorgebucaran wanna try it?
_purge_configs
&_disable_colors
execution to test container_pure_user_at_host
test
arguments@mesg
by@echo
setup
andteardown