move space in prompt causing bad formatting in single line mode #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By moving the space to the beginning, it fixes the virtualenv from being badly formatted with first prompt line.
|
Hello @speyejack, |
|
/close in favour of #296 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving the space to the beginning, it fixes the virtualenv from
being badly formatted with first prompt line.
I'm not sure why the string trimming in
_pure_print_promptdoes not remove this space, however, it does seem to fix the problem with the single line formatting mentioned in #276. It also fixes the double spaced issue with virtualenv mentioned as well. I also briefly checked it with double new line formatting and I didn't noticed any issues.