-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for psc-package #289
Conversation
@hdgarrood Hmm now there was no Appveyor run 😆 Maybe because of the purescript-contrib move? Also there was one comment regarding the readme that I hadn't addressed. |
Ok, I'll try to get that sorted. I did already tell AppVeyor about the move... In the meantime, how much have you thought about what e.g. |
I decided on defaulting to psc-package in that scenario since there's already a parameter for specifying the Bower file, so if you have both and want build with Bower you just do |
It's just that I'm a little reluctant to do that, because it would be a fairly significant departure from what |
Ok sure, since I added a |
Yes, I think that might be better. |
Ok, AppVeyor is up and running again but in the meantime I accidentally caused a conflict. Would you mind rebasing? Sorry! |
This is looking great and I think we are pretty much there. I just think the readme needs to be updated slightly to be more explicit about psc package vs bower selection, and how to make pulp use psc package when you have both files in your project. We might also want to suggest using npm scripts so that you don't have to write --psc-package all the time? Does the readme mention npm scripts already? |
I have added some clarification on that in the readme now, do you think this is sufficient? It seems that AppVeyor hit the rate limit. |
I'll merge this for now so that AppVeyor can use my GitHub token and bypass the rate limit, and I'll have a think about what to do with the README. Other than that is there anything else, do you think? |
Ok cool. I just pushed an update to use the most recent |
Resolves #243
Projects using both psc-package and Bower will default to building with psc-package dependencies, but --bower-file -b overrides that.