Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate isDigit and digitToInt in favor of functions which specify base #31

Merged
merged 7 commits into from Dec 16, 2020

Conversation

milesfrain
Copy link
Member

@milesfrain milesfrain commented Dec 11, 2020

Description of the change
Fixes #25

Now we have symmetric:

isHexDigit        
isDecDigit        
isOctDigit        
hexDigitToInt        
decDigitToInt        
octDigitToInt

Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Added a test for the contribution (if applicable)

Not Applicable:

  • Updated or added relevant documentation in the README and/or documentation directory
    • I think the API docs in the function comments are enough in this case.

Copy link
Contributor

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Rename digitToInt as hexDigitToInt, create new decimal-only digitToInt
2 participants