Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a variant of slot to ignore child output #642

Merged
merged 1 commit into from
Feb 16, 2020

Conversation

paul-rouse
Copy link
Contributor

The discussion of #636 mentioned the slight inconvenience of replacing const Nothing when child output messages need to be ignored. I had several of these in one of the projects I'm testing against next-6.

How about adding a variant of slot which ignores outputs? It ccould also be used in the Void case, slightly simplifying things there, too. Here's an implementation, but I'm not sure about the name slot_; I wanted to avoid slot' since that meant something different up to version 4.

I realise this makes use of the fact that the Maybe is still there in the underlying implementation, and you may have been intending to remove that sometime in the future, so feel free to ignore this PR if there is a better direction to go!

@paul-rouse paul-rouse changed the title [WIP] Add a variant of slot to ignore child output Add a variant of slot to ignore child output Feb 12, 2020
@garyb
Copy link
Member

garyb commented Feb 16, 2020

Seems reasonable to me - and I think the slot_ name makes sense, as underscore-suffixed things often imply some kind of result is being ignored. Thanks!

@garyb garyb merged commit 60597ba into purescript-halogen:next-6 Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants