-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate project to Spago #653
Migrate project to Spago #653
Conversation
}, | ||
"devDependencies": { | ||
"pulp": "^13.0.0", | ||
"purescript": "^0.13.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd rather keep PS as an explicit dependency rather than grabbing the latest.
Although we've just switched over all the core/contrib repos to grab the latest compiler, that was kinda leftover from the days where we weren't free to make an npm release whenever we wanted. I think depending on a specific compiler version is preferable for libraries, rather than always grabbing the latest, since it might well be that there's a window where we're not compatible with the latest compiler. It can especially happen in projects with lots of dependencies, since everything upstream needs to be ready also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me! I've added PureScript back as a dev dependency and reverted that part of the Travis script.
This PR makes the following updates:
effect
explicitly as a dependency. It was already included transitively via several other dependencies, so including it isn't really a change.purescript-contrib
libraries.There are no changes to the underlying library or other code outside of simple tweaks needed to make sure everything's up to date. Just a simple transition from Bower -> Spago.
I verified that the new Bower file includes dependencies at the same major versions as the current Bower file.