Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate project to Spago #653

Merged
merged 10 commits into from
May 10, 2020
Merged

Migrate project to Spago #653

merged 10 commits into from
May 10, 2020

Conversation

thomashoneyman
Copy link
Member

@thomashoneyman thomashoneyman commented May 8, 2020

This PR makes the following updates:

  1. Switches the Halogen repository to use Spago as the package manager, including switching all examples to be Spago-based. With this update it also removes all references to Bower.
  2. Uses a new Bower file generated by Spago. This is the same as the old one, as far as Pursuit / publishing is concerned, but with one change: it now includes effect explicitly as a dependency. It was already included transitively via several other dependencies, so including it isn't really a change.
  3. Updates the Travis file to always point at the latest version of the PureScript compiler as is done in the purescript-contrib libraries.
  4. Deletes the GUIDE.md link, as the /docs folder has been around for years now and there are no links to this file within the repository.

There are no changes to the underlying library or other code outside of simple tweaks needed to make sure everything's up to date. Just a simple transition from Bower -> Spago.

I verified that the new Bower file includes dependencies at the same major versions as the current Bower file.

@thomashoneyman thomashoneyman requested a review from garyb May 8, 2020 21:12
@thomashoneyman thomashoneyman self-assigned this May 8, 2020
},
"devDependencies": {
"pulp": "^13.0.0",
"purescript": "^0.13.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd rather keep PS as an explicit dependency rather than grabbing the latest.

Although we've just switched over all the core/contrib repos to grab the latest compiler, that was kinda leftover from the days where we weren't free to make an npm release whenever we wanted. I think depending on a specific compiler version is preferable for libraries, rather than always grabbing the latest, since it might well be that there's a window where we're not compatible with the latest compiler. It can especially happen in projects with lots of dependencies, since everything upstream needs to be ready also.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! I've added PureScript back as a dev dependency and reverted that part of the Travis script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants