Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various imports error/warnings entries #159

Merged
merged 3 commits into from
Jan 14, 2018

Conversation

nwolverson
Copy link
Contributor

No description provided.

@hdgarrood
Copy link
Collaborator

This might be a good opportunity to make a start on #158. Also would you mind changing "This error is auto-fixable" to "This warning is auto-fixable"? Finally do you think there's something we can link to which explains what that means?

@nwolverson
Copy link
Contributor Author

Yeah I was considering taking a pass at a bunch of the imports issues. I want to indicate the class of warnings that the compiler provides suggestions to fix which can be applied with purescript-suggest, pscid or editor plugins - I wonder if there's a better wording which can be used consistently.

Should I maybe create a page in guides/ which can be linked to that explains these options?

@hdgarrood
Copy link
Collaborator

I think the wording is fine, I'm just a little concerned about how useful it will be for people who don't have the context.

Should I maybe create a page in guides/ which can be linked to that explains these options?

That would be great 👍

@nwolverson nwolverson changed the title Create UnusedImport.md Various imports error/warnings entries Jan 7, 2018
@nwolverson
Copy link
Contributor Author

I've added a short error suggestions guide, and linked this, also went through a batch of warnings around imports.

@chexxor
Copy link
Collaborator

chexxor commented Jan 14, 2018

LGTM 👍

@hdgarrood
Copy link
Collaborator

Thanks!

@hdgarrood hdgarrood merged commit 9efcc2b into purescript:master Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants