Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cirru-parser #883

Merged
merged 1 commit into from
Mar 21, 2021
Merged

Conversation

tiye
Copy link
Contributor

@tiye tiye commented Mar 20, 2021

Corresponded PR in https://github.com/purescript/registry/pull/147/files . First time to submit package here...

I got a some confusions:

  1. in dependencies field, I listed the packages I used manually. however among them the packages used in tests are not listed. when I was in Node.js there are dependencies and devDependencies. is that okay I leave out the devDependencies part in this?
  2. does it also mean I need to PR every time I bumped version since version is locked here, even though my package is still in early stage? I tried but it appears I can't run pulp publish without the depended package listed in package-sets, I Googled many times and didn't see a way of maintaining dependencies locally(given that my package still in early stage and will probably change).

@tiye tiye force-pushed the add-cirru-parser branch 2 times, most recently from 4793d8e to bf813bc Compare March 20, 2021 12:05
@thomashoneyman
Copy link
Member

thomashoneyman commented Mar 20, 2021

in dependencies field, I listed the packages I used manually. however among them the packages used in tests are not listed. when I was in Node.js there are dependencies and devDependencies. is that okay I leave out the devDependencies part in this?

Yes, you should leave out dev dependencies and only include dependencies used in your source.

does it also mean I need to PR every time I bumped version since version is locked here, even though my package is still in early stage? I tried but it appears I can't run pulp publish without the depended package listed in package-sets, I Googled many times and didn't see a way of maintaining dependencies locally(given that my package still in early stage and will probably change).

Yes, the version is locked here. You can either PR each time you bump the version, or you can wait for us to pick up the change (we update versions every couple days and check for updates automatically).

You don't have to have your library and its dependencies in the package set in order to work on it. You can rely on your packages locally -- see the section of the Spago documentation about overriding the package set to a local package.

Note that pulp doesn't know anything about package sets; pulp publish is used to push your package documentation to Pursuit and it uses your local bower.json file to do so, but it's unrelated to package sets.

There's one last thing -- if you are failing to run pulp publish because you have a dependency listed in your bower.json (like cirru-parser) and Bower says it doesn't know about the package, then that means that you published the package after the Bower registry officially closed. In that case, just make sure to provide the full Git URL to Bower instead of just the package name. For example:

- "cirru-parser": "^1.0.0"
+ "cirru-parser": "https://github.com/jiyinyiyong/purescript-cirru-parser.git#^1.0.0"

@tiye
Copy link
Contributor Author

tiye commented Mar 21, 2021

thanks a lot.

- "cirru-parser": "^1.0.0"
+ "cirru-parser": "https://github.com/jiyinyiyong/purescript-cirru-parser.git#^1.0.0"

this looks a lot like what I saw in Nim packages 😄

@thomashoneyman thomashoneyman merged commit 5e31208 into purescript:master Mar 21, 2021
@tiye tiye deleted the add-cirru-parser branch March 21, 2021 05:19
@tiye
Copy link
Contributor Author

tiye commented Mar 24, 2021

it has been 3+ days, could you tag a new release?

@thomashoneyman
Copy link
Member

psc-0.14.0-20210324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants