Skip to content

Commit

Permalink
Avoid Data.ByteString.Lazy.toStrict (#3433)
Browse files Browse the repository at this point in the history
  • Loading branch information
coot authored and kritzcreek committed Sep 24, 2018
1 parent fb8daff commit 5ab1a79
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
5 changes: 2 additions & 3 deletions app/Command/Bundle.hs
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ import System.Exit (exitFailure)
import System.IO (stderr, hPutStr, hPutStrLn)
import System.IO.UTF8 (readUTF8File, writeUTF8File)
import System.Directory (createDirectoryIfMissing, getCurrentDirectory)
import qualified Data.ByteString.Lazy as B
import qualified Data.ByteString.UTF8 as BU8
import qualified Data.ByteString.Lazy.UTF8 as LBU8
import Language.PureScript.Bundle
import Options.Applicative (Parser)
import qualified Options.Applicative as Opts
Expand Down Expand Up @@ -123,6 +122,6 @@ command = run <$> (Opts.helper <*> options) where
case sourcemap of
Just sm -> do
writeUTF8File outputFile $ js ++ "\n//# sourceMappingURL=" ++ (takeFileName outputFile <.> "map") ++ "\n"
writeUTF8File (outputFile <.> "map") $ BU8.toString . B.toStrict . encode $ generate sm
writeUTF8File (outputFile <.> "map") $ LBU8.toString . encode $ generate sm
Nothing -> writeUTF8File outputFile js
Nothing -> putStrLn js
5 changes: 2 additions & 3 deletions app/Command/Compile.hs
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ import Control.Applicative
import Control.Monad
import qualified Data.Aeson as A
import Data.Bool (bool)
import qualified Data.ByteString.Lazy as B
import qualified Data.ByteString.UTF8 as BU8
import qualified Data.ByteString.Lazy.UTF8 as LBU8
import Data.List (intercalate)
import qualified Data.Map as M
import qualified Data.Set as S
Expand Down Expand Up @@ -51,7 +50,7 @@ printWarningsAndErrors verbose False warnings errors = do
exitFailure
Right _ -> return ()
printWarningsAndErrors verbose True warnings errors = do
hPutStrLn stderr . BU8.toString . B.toStrict . A.encode $
hPutStrLn stderr . LBU8.toString . A.encode $
JSONResult (toJSONErrors verbose P.Warning warnings)
(either (toJSONErrors verbose P.Error) (const []) errors)
either (const exitFailure) (const (return ())) errors
Expand Down
4 changes: 2 additions & 2 deletions src/Language/PureScript/Make/Actions.hs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import Control.Monad.Writer.Class (MonadWriter(..))
import Data.Aeson (encode)
import qualified Data.ByteString.Lazy as B
import qualified Data.ByteString.Lazy as LB
import qualified Data.ByteString.UTF8 as BU8
import qualified Data.ByteString.Lazy.UTF8 as LBU8
import Data.Either (partitionEithers)
import Data.Foldable (for_, minimum)
import qualified Data.List.NonEmpty as NEL
Expand Down Expand Up @@ -229,7 +229,7 @@ buildMakeActions outputDir filePathMap foreigns usePrefix =
checkForeignDecls :: CF.Module ann -> FilePath -> SupplyT Make ()
checkForeignDecls m path = do
jsStr <- lift $ readTextFile path
js <- either (errorParsingModule . Bundle.UnableToParseModule) pure $ JS.parse (BU8.toString (B.toStrict jsStr)) path
js <- either (errorParsingModule . Bundle.UnableToParseModule) pure $ JS.parse (LBU8.toString jsStr) path

foreignIdentsStrs <- either errorParsingModule pure $ getExps js
foreignIdents <- either
Expand Down

0 comments on commit 5ab1a79

Please sign in to comment.