Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad results from the expression pretty printer #2039

Closed
LiamGoodacre opened this issue Apr 19, 2016 · 7 comments
Closed

Bad results from the expression pretty printer #2039

LiamGoodacre opened this issue Apr 19, 2016 · 7 comments

Comments

@LiamGoodacre
Copy link
Member

The following appears in the error message for the expression: (let o = {a: 0} in o).b

(let           ."b"
   o = { a: ...
       }
 in o
)

Firstly the "b" is quoted. Secondly it's in the wrong place 馃槂

@natefaubion
Copy link
Contributor

Its not in the wrong place if you think of the expressions as being side by side 馃槅

@garyb
Copy link
Member

garyb commented Apr 19, 2016

Which is exactly what I think is happening 馃槈 <> in boxes joins things top & horizontally I think.

@LiamGoodacre
Copy link
Member Author

Woah, quoting is somewhat correct? I didn't know this was valid: _."a m a z i n g" !

@garyb
Copy link
Member

garyb commented Apr 19, 2016

Yeah, it's the PS equivalent to obj["foo"] in JS, only it's restricted to literal strings, not expressions. It's so you can have record fields with keyword names and the like. The record syntax is { "s i m i l a r": true }.

@LiamGoodacre
Copy link
Member Author

Noticed some other oddities with the quoting - PR incoming 馃槂

@paf31
Copy link
Contributor

paf31 commented Apr 20, 2016

We have a combinator for this sort of layout, I think.

@paf31 paf31 added this to the 0.10.0 milestone Apr 20, 2016
@nwolverson
Copy link
Contributor

Side by side rendering is really confusing.

nwolverson/atom-ide-purescript#112 (search 'psci')

@paf31 paf31 modified the milestones: 0.9.4, 0.10.0 Aug 1, 2016
@paf31 paf31 modified the milestones: 0.9.4, 0.10.0, 1.0.0 Sep 17, 2016
@paf31 paf31 changed the title Funky code rendering Bad results from the expression pretty printer Oct 1, 2016
@paf31 paf31 modified the milestones: 1.0, Approved Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants