New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove derived JSON instances for Type #3494
Comments
refs #2655 |
What is the status on using aeson-better-errors vs just aeson? The kind codecs use better-errors, but things like corefn just use aeson. Is there a preference? |
aeson-better-errors only deals with the parsing direction; I think we generally use standard aeson for producing json, and aeson-better-errors for parsing it. The ide code seems to use standard aeson for both directions, though. There's not any huge reason to prefer one over the other these days, I don't think, as a little while after I first released aeson-better-errors, aeson's own errors improved to be more or less on par with it. The one thing I would say is that I think aeson-better-errors' API is a bit better suited for hand-written instances. |
* Switch psc-publish tests to use hspec * Add tests for json compatibility refs purescript#2655, purescript#3494
#3484 added annotations to
Type
which technically breaks compatibility since the JSON instances are derived. We should remove these and do something similar to what we've done with theKind
codecs before the next release.The text was updated successfully, but these errors were encountered: