Use handwritten JSON instances for Type/Kind #3496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natefaubion
commented
Dec 23, 2018
| toJSON = kindToJSON toJSON | ||
|
|
||
| kindFromJSON :: forall a. Parser a -> (Value -> Parser a) -> Value -> Parser (Kind a) | ||
| kindFromJSON defaultAnn annFromJSON = A.withObject "Kind" $ \o -> do |
There was a problem hiding this comment.
I removed the old kind parsing from 0.10. I don't think it's necessary to preserve these anymore.
natefaubion
commented
Dec 23, 2018
| KUnknown <$> annFromJSON' <*> key "contents" (nth 0 asIntegral) | ||
| "Star" -> | ||
| kindType <$> defaultAnn | ||
| KUnknown a <$> contents |
There was a problem hiding this comment.
I'm pretty sure this parser was broken. It appears to parse with nth 0, but it was not encoded with a wrapper list.
|
Are these codecs exercised by the Docs tests? I guess the |
|
They are only partially exercised by the Docs tests; we only test that the parser is compatible with the json produced by the current version. I've been meaning to add some tests to ensure that we don't accidentally break compatibility, because we don't have those right now. |
hdgarrood
approved these changes
Dec 23, 2018
|
I have not looked into it. Be my guest 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3494
I think this should be compatible, though I'm not super familiar with Aeson's encoding. I don't think there are any tests for these, but I can probably add some.