-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better re-export handling #1418
Conversation
All green at last! |
👍 Thanks! Edit: Actually, after I |
They run okay for me now, did you make those changes for v0.7.0-rc.2 after posting this? The changes you made look right to me - you can't export a module anymore unless you import it, the reasoning for this being only the specific values imported into the current module are re-exported when you export a module. |
The tests run ok? I get |
Yep. Tried cleaning the output folder? |
Yup, definitely works for me - I just installed the |
Yes, I just removed |
Yes, I don't see module reexports in the externs files. Is that an issue? |
Seems like it would be an issue if we want to support separate compilation without looking at original source files. |
#1425 should sort that out. |
Changes Unknown when pulling 55ba265 on 1244-reexports into ** on master**. |
Resolves #1244. Resolves #291 in a slightly different way too (if
A
explicitly imports values fromB
and then re-exportsB
, only the values it imported will be re-exported).