-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hints #1516
Hints #1516
Conversation
I'd say this resolves #1357. |
This also simplifies the approach to position info slightly. Position errors always get consed to the front of the hint list, which means the most specific position data is usually at the end of the list. By reversing before picking unique hints by category, we automatically get the most specific position info. |
Resolves #909 |
Sounds awesome, but think this will take me a while to digest, so it'll probably be tomorrow before I get time to read it properly. |
Remove inferProperty judgment
Warnings for missing top-level type declarations, fix #1333
@garyb Unless you see anything major, I'll tidy a couple of things up and merge into |
Sure thing. Code looks good to me too, I haven't tried it out yet but the idea behind it sounds solid. |
@garyb Does this look ok? I think it simplifies things nicely and gives a nicer set of error messages.
Basically the new simplification rules is: take at most one hint from each hint category.
Thanks.