Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1557 #1559

Closed
wants to merge 1 commit into from
Closed

Fix #1557 #1559

wants to merge 1 commit into from

Conversation

paf31
Copy link
Contributor

@paf31 paf31 commented Oct 24, 2015

/cc @garyb

Example message:

Error found:
Error in module M1:
--------------------------------------------------------------------------------
Error in value declaration compose:
--------------------------------------------------------------------------------
Error at test.purs line 4, column 15 - line 4, column 19:
--------------------------------------------------------------------------------
Error checking type of property accessor

  g."f"

--------------------------------------------------------------------------------
Error checking that expression

  g

has type

  { f :: _0 -> _1
  | _2
  }

--------------------------------------------------------------------------------
Error while trying to match type

  Object

with type

  Function _3

--------------------------------------------------------------------------------
Could not match expected type

  Object

with actual type

  Function _3

--------------------------------------------------------------------------------

This commit also removes some stuff to do with the order in which hints get rendered, because it was almost always wrong.

Also, how do you like the line breaks? This commit doesn't include them, but I'm trying to find a nice way to vertically separate different bits in an error message. Another option might be to indent pieces and punctuate them with something like "Caused by:"

@paf31 paf31 closed this Oct 25, 2015
@paf31 paf31 deleted the 1557 branch October 25, 2015 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant