adding qualified name lookup for psci :browse issue #974 #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Nothing -> | ||
| PSCI $ outputStrLn $ "Module '" ++ N.runModuleName moduleName ++ "' is not valid." | ||
| Just qualifiedName -> | ||
| handleBrowse qualifiedName |
There was a problem hiding this comment.
Here, we're running make twice. Can we avoid that?
There was a problem hiding this comment.
We can just copy and run the if on line 489 again instead, would that be better?
There was a problem hiding this comment.
Well, let's not copy it. Maybe we can extract it into a separate function.
|
@garyb Let's include this one in 0.8, yes? |
|
Sure, sounds good to me 👍 |
| failNotInEnv moduleName | ||
| where | ||
| isModInEnv modName st = | ||
| isJust $ find ((\ (P.Module _ _ mName _ _ ) -> mName == modName) . snd) (psciLoadedModules st) |
There was a problem hiding this comment.
Also, you can then eta-reduce:
isModInEnv modName = any ((== modName) . getModuleName . snd) . psciLoadedModules
|
@soupi I added a couple more comments here. If you could have a quick look, I'll get this merged in before the next RC. Thanks! |
|
@paf31 thanks for the suggestions! I made the changes and squashed the commits by doing a force push. I hope that's alright. |
paf31
added a commit
that referenced
this pull request
Jan 24, 2016
adding qualified name lookup for psci :browse issue #974
|
Thanks very much! |
|
gladly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as requested here.