Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix core-tests #2162

Merged
merged 2 commits into from
May 25, 2016
Merged

Fix core-tests #2162

merged 2 commits into from
May 25, 2016

Conversation

paf31
Copy link
Contributor

@paf31 paf31 commented May 25, 2016

No description provided.

@paf31 paf31 added this to the 0.9.1 milestone May 25, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.185% when pulling 05406fb on core-tests-2 into f148735 on 0.9.

@hdgarrood
Copy link
Contributor

👍 although is there any way we can keep the psc-docs test in? The re-export handling code has caused a few internal errors in the past, and while I think they're all fixed now, it would definitely make me happier to know that at least the core libraries don't cause any.

@paf31
Copy link
Contributor Author

paf31 commented May 25, 2016

How's this?

@hdgarrood
Copy link
Contributor

Looks great! 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.185% when pulling bed9bc5 on core-tests-2 into f148735 on 0.9.

@paf31 paf31 merged commit 83be9a5 into 0.9 May 25, 2016
@paf31 paf31 deleted the core-tests-2 branch May 25, 2016 17:55
archaeron pushed a commit to archaeron/purescript that referenced this pull request Apr 6, 2017
@paf31 @archaeron
Fix core-tests (purescript#2162)
0c0a5e5 
* Fix core-tests

* test psc-docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: ready for review
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paf31 @coveralls @hdgarrood