Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protolude 0.1.6: fix ambiguous occurrences #2225

Merged

Commits on Jul 19, 2016

  1. protolude 0.1.6: fix ambiguous occurrences

    Prevent PureScript build failure with protolude 0.1.6 due to
    ambiguous occurrence errors arising from the following conflicts:
    
      Protolude.fromStrict vs. Data.ByteString.Lazy.fromStrict
      Protolude.decodeUtf8 vs. Data.Text.Lazy.Encoding.decodeUtf8
      Protolude.encodeUtf8 vs. Data.Text.Lazy.Encoding.encodeUtf8
    
    In order to preserve the ability to use "fromStrict" without qualifying
    it (e.g., Z.fromStrict), this fixes the ambiguous occurrences in a way
    that is backwards incompatible with protolude 0.1.5. In particular,
    using fromStrict without qualification requires hiding it, but since
    protolude 0.1.5 doesn't actually export fromStrict, importing 0.1.5
    hiding fromStrict will trigger a dodgy imports warning.
    
    Bumping the protolude dependency to >= 0.1.6 requires bumps to
    PureScript's designated Stack LTS and Nightly resolvers. Switching to
    lts-6.7 and nightly-2016-07-19 requires a few unrelated fixes:
    
    System.FilePath: remove redundant imports (-Wunused-imports)
    parseURL: replace with non-deprecated parseRequest (-Wdeprecations)
    fromJust: import from Data.Maybe instead of Unsafe (prevents error)
    
    Also set protolude >=0.1.6 and http-client >= 0.4.30 (for parseRequest)
    in purescript.cabal, and update the CONTRIBUTORS file.
    ilovezfs committed Jul 19, 2016
    Configuration menu
    Copy the full SHA
    b2e4800 View commit details
    Browse the repository at this point in the history