Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further conversions to Text in Docs modules #2502

Merged
merged 3 commits into from Dec 24, 2016
Merged

Further conversions to Text in Docs modules #2502

merged 3 commits into from Dec 24, 2016

Conversation

hdgarrood
Copy link
Contributor

No description provided.

@hdgarrood
Copy link
Contributor Author

The majority of this was fairly obvious and mindless, I just changed the data declarations and then fixed all the compile errors. The only bits weren't were small bits in Language.PureScript.Publish where it calls other executables, and also bits of the Docs stuff which depend on other libraries that still use String, such as bower-json, so there are a still a few occurrences of T.pack and T.unpack dotted about. I plan to come back to this later but I think this is already a big improvement and didn't want to try to do too much in one go.

Copy link
Contributor

@paf31 paf31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@paf31 paf31 merged commit 1c5a431 into master Dec 24, 2016
@paf31 paf31 deleted the docs-text branch December 24, 2016 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants