Add command to apply minor package updates #2510
Conversation
|
|
||
| parseVersion :: Text -> Maybe [Int] | ||
| parseVersion ref = | ||
| case T.stripPrefix "v" ref of |
There was a problem hiding this comment.
psc-publish doesn't require the 'v' prefix, i.e. it also works if you use just "1.0.0" as your tagged version instead of "v1.0.0" so perhaps this should work in the same way?
There was a problem hiding this comment.
Alternatively, we could change psc-publish to require the leading 'v'; I think most people do include it.
There was a problem hiding this comment.
Thanks!
Updated to require the v prefix in psc-publish. How does this look now?
There was a problem hiding this comment.
Looks good. I think it will be a great improvement to have a one-to-one correspondence between versions and expected forms of tags (in fact I probably would have done it that way in the first place if I'd thought about it a bit more).
I think we should also remove the pkgVersionTag from the definition of Package in Docs.Types, but continue adding the field in the ToJSON instance for now for backwards compatibility. We can add a TODO comment to remove it the next time we break the JSON format.
There was a problem hiding this comment.
Sounds good, but should that be part of this PR?
There was a problem hiding this comment.
Good point; no, I think we could do that separately afterwards.
| @@ -148,9 +148,8 @@ displayUserError e = case e of | |||
| , "version." | |||
| ]) | |||
| , spacer | |||
| , para "Note: tagged versions must be in one of the following forms:" | |||
| , para "Note: tagged versions must be in the following form:" | |||
There was a problem hiding this comment.
Would it make sense to remove the bullet point now that there's only one form listed?
There was a problem hiding this comment.
Yes, of course, thanks :)
This command checks for new tags on all repos and can also apply minor updates automatically. I've used it to update the package set and also find all those packages which are currently not on the latest major version.