Check warnings/errors for positions #3211
Conversation
|
|
|
Look again 😉 maybe GH being slow, it was in the original commit but I amended it and re-pushed before opening the PR. |
garyb
force-pushed
the
missing-positions
branch
from
fcf9f81
to
5703b4c
Compare
| @@ -47,7 +47,6 @@ opTable | |||
| -> [[P.Operator (Chain a) () Identity a]] | |||
| opTable ops fromOp reapply = | |||
| map (map (\(name, a) -> P.Infix (P.try (matchOp fromOp name) >> return (reapply name)) (toAssoc a))) ops | |||
| ++ [[ P.Infix (P.try (parseOp fromOp >>= \ident -> return (reapply ident))) P.AssocLeft ]] | |||
There was a problem hiding this comment.
Did the change from #3212 accidentally sneak in here? ;) https://github.com/purescript/purescript/pull/3212/files
There was a problem hiding this comment.
It didn't sneak in no, it's kinda required since reapply needs a source position now, and this case can't provide one (unless / until the entire AST has source positions).
I've been considering how to test it since seeing Phil's reply to #3212, as it didn't break any of the existing tests.
There was a problem hiding this comment.
Oh, er, maybe it snuck into this specific PR after all, but one of the others I opened about the same time makes the above comment true.
|
I'm going to merge this when it actually passes, so when #3208 is finished basically :) |
garyb
force-pushed
the
missing-positions
branch
from
5703b4c
to
5a7a49b
Compare
|
This now passes 🎉 (it's based on top of #3318) |
garyb
force-pushed
the
missing-positions
branch
from
5a7a49b
to
2d5b418
Compare
No description provided.