-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing output directory to error #3311
Conversation
Please add yourself to the CONTRIBUTORS.md file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just a few comments
src/Language/PureScript/Ide.hs
Outdated
@@ -167,7 +167,7 @@ findAvailableExterns :: (Ide m, MonadError IdeError m) => m [P.ModuleName] | |||
findAvailableExterns = do | |||
oDir <- outputDirectory | |||
unlessM (liftIO (doesDirectoryExist oDir)) | |||
(throwError (GeneralError "Couldn't locate your output directory.")) | |||
(throwError (GeneralError $ "Couldn't locate your output directory: " <> (toS oDir) <> ".")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of Couldn't locate your output directory at: ...
? Makes it a little clearer that we went searching for it.
Could we run the path through System.FilePath.normalise
and use an explicit T.pack
over toS
? I also think we should leave off the trailing .
since it'll be in the way when copy pasting the path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
Great, thanks! |
No description provided.