add Boolean kind to Prim.Boolean #3389
Conversation
|
Builds timed out. Could someone re-run them if that's the issue? |
src/Language/PureScript/Constants.hs
Outdated
| pattern SymbolContains = Qualified (Just PrimSymbol) (ProperName "Contains") | ||
|
|
||
| pattern SymbolBreakOn :: Qualified (ProperName 'ClassName) | ||
| pattern SymbolBreakOn = Qualified (Just PrimSymbol) (ProperName "BreakOn") |
There was a problem hiding this comment.
Did you mean to add these in this PR?
There was a problem hiding this comment.
oh, sorry, applied a patch but it was wrong 😅, i'll try to get around to updating it later
|
I restarted the timed out build. |
|
4/5 ran within time this time through... |
|
If you need to restart the build and don't have access to it on Travis, you can close this PR and open it again. It will restart the build. I think it means all builds will run again, but it beats waiting for someone else to come along. |
|
No, please don’t do that - instead push an empty commit (as the CI log should suggest). As far as I’m aware that’s the only way to get travis to reuse the progress it made during its previous attempt. |
|
I've restarted the failing job a couple of times fwiw 😕 |
|
Restarting jobs which have timed out is generally not very effective in my experience; we should be encouraging the submitter to push empty commits instead. |
|
(Instead of empty commits you can regenerate your existing commit with |
|
An alternate to any of our suggestions could be focusing on making CI more reliable 😄. |
|
Amending and force pushing doesn’t work either. I think Travis must take the cache from the parent commit each time. Incidentally I spent quite a lot of time on this script and I’m fairly confident it’s the best we can do without moving to a different CI platform. |
|
The previous amend was to address some mistaken code being added, let's see an empty commit |
Just to expand on this a little: I will accept without reservation that this is a pretty sorry state of affairs. I would love to be proven wrong on the above but unfortunately I really do think it’s very unlikely. |
|
Looks like we build the haddocks for dependencies of every job in the matrix whether it has Is it this line? Lines 8 to 10 in f8ca834 I'm more than willing to submit a PR for it. |
|
@joneshf I applied that suggestion in my fork here purerl@5b656c8 - not quite sure if it helped or I just had stuff cached by this point, but I think by my understanding this should be right - I believe the cache will be separate for the different entries in our build matrix |
|
Sorry for the delay in responding. Good spot - yes I think that would help. |
justinwoo
force-pushed
the
prim-boolean
branch
2 times, most recently
from
6cfffb9
to
aa3d6ef
Compare
|
Heyy, this passed now :) |
src/Language/PureScript/Docs/Prim.hs
Outdated
| @@ -329,6 +343,21 @@ partial = primClass "Partial" $ T.unlines | |||
| , "[the Partial type class guide](https://github.com/purescript/documentation/blob/master/guides/The-Partial-type-class.md)." | |||
| ] | |||
|
|
|||
| kindBoolean :: Declaration | |||
| kindBoolean = primKindOf (P.primSubName "Boolean") "Boolean" $ T.unlines | |||
| [ "The `Boolean` kind provides a the type-level True/False types" | |||
justinwoo
force-pushed
the
prim-boolean
branch
2 times, most recently
from
9d67c5f
to
599a0c4
Compare
|
Cleaned up now. I can rebase #3383 later, and I think I might implement Row.Contains also since sometimes I've needed that and it's similar to the old RowLacks that was expensive as a library |
|
Some of the BreakOn and Contains stuff is still in this PR, @justinwoo ? |
justinwoo
force-pushed
the
prim-boolean
branch
from
599a0c4
to
08f512e
Compare
|
Finally removed it |
Adds Boolean kind and True/False types of Boolean to Prim.Boolean. Related to #3383
Corresponding typelevel-prelude change: justinwoo/purescript-typelevel-prelude@b82137f