Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graph command for graphing module dependencies #3781

Merged
merged 4 commits into from
Feb 1, 2020

Conversation

f-f
Copy link
Member

@f-f f-f commented Jan 30, 2020

This builds on #3635, but shuffles files a bit, fixes some styling, and adds a test for it.

Closes #3635

Copy link
Member

@kritzcreek kritzcreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a bit more work, and the tests are failing on Windows because of the different Path separators. Thanks for picking this up @f-f!

app/Command/Graph.hs Outdated Show resolved Hide resolved
src/Language/PureScript/Graph.hs Show resolved Hide resolved
src/Language/PureScript/Graph.hs Outdated Show resolved Hide resolved
src/Language/PureScript/Graph.hs Show resolved Hide resolved
src/Language/PureScript/Graph.hs Outdated Show resolved Hide resolved
src/Language/PureScript/Graph.hs Outdated Show resolved Hide resolved
Copy link
Member

@kritzcreek kritzcreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit left, Thanks again!

src/Language/PureScript/Graph.hs Outdated Show resolved Hide resolved
@kritzcreek kritzcreek merged commit 27f6cf0 into purescript:master Feb 1, 2020
@afcondon
Copy link

afcondon commented Feb 3, 2020

Very excited about this feature! (so excited i had to build purs and check it really works!

Is there some off the shelf visualizer that handles that format? Just asking before i write something unnecessary (i would probably try and turn it into either dot or something directly importable as a D3js force layout, i think)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants