Relax purescript-ast dependency to microlens
#3817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`microlens-platform` brings in quite a bit of extra dependencies. To thin out what `purescript-ast` depends on, we move from `microlens-platform` to `microlens`.
natefaubion
approved these changes
Mar 22, 2020
|
Thanks for the review! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microlens-platformis made to bring in a bunch of other dependencies so working with a small lens package isn't tedious. It's made for an application.microlensis made to be as minimal as possible. It's made so it doesn't increase the footprint of a package onto everyone that depends on that package. Now thatpurescript-astis its own package, we drop the dependency down tomicrolensinstead ofmicrolens-platform, removing transitive dependencies in the process.There should be no noticeable changes as far as API goes.