Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better row unification error messages #4421

Open
wants to merge 47 commits into
base: master
Choose a base branch
from
Open

Better row unification error messages #4421

wants to merge 47 commits into from

Commits on Nov 29, 2022

  1. Try to show which labels are mismatched as well

    @FredTheDino
    FredTheDino committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    4975df0 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2022

  1. Revert "Try to show which labels are mismatched as well" 

    This reverts commit 4975df0.
    @FredTheDino
    FredTheDino committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    47aff37 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Display a merged error message

    @FredTheDino
    FredTheDino committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    7b4c4d6 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Revert "Display a merged error message" 

    This reverts commit 7b4c4d6.
    @FredTheDino
    FredTheDino committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    c0cd73d View commit details
    Browse the repository at this point in the history

  2. Add testcases for more record errors

    @FredTheDino
    FredTheDino committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    ef71d77 View commit details
    Browse the repository at this point in the history

  3. Add test output before changes

    @FredTheDino
    FredTheDino committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    b5e4f81 View commit details
    Browse the repository at this point in the history

  4. Change the error generation code

    @FredTheDino
    FredTheDino committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    335b873 View commit details
    Browse the repository at this point in the history

  5. Change a sequence into a parU 

    Changes to tests after typecheck changes
    @FredTheDino
    FredTheDino committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    5969058 View commit details
    Browse the repository at this point in the history

  6. Update the test output after changes

    @FredTheDino
    FredTheDino committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    3cb3074 View commit details
    Browse the repository at this point in the history

  7. Add test for parU change

    @FredTheDino
    FredTheDino committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    9c1c4f4 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Merge remote-tracking branch 'origin/master' into HEAD 

    # Conflicts:
#	src/Language/PureScript/TypeChecker/Unify.hs
    @MonoidMusician
    MonoidMusician committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    fe37bdc View commit details
    Browse the repository at this point in the history

  2. Commit test changes from merge

    @MonoidMusician
    MonoidMusician committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    7041b93 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Merge remote-tracking branch 'origin/master' into types-do-not-unify-… 

    …row-type-clearification
    @JordanMartinez
    JordanMartinez committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    48c33f6 View commit details
    Browse the repository at this point in the history

  2. Make types in error message different

    @JordanMartinez
    JordanMartinez committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    03ba84a View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Report both errors in nested error

    @JordanMartinez
    JordanMartinez committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    af8260b View commit details
    Browse the repository at this point in the history

  2. Test out substituteType approach

    @JordanMartinez
    JordanMartinez committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    d4cf721 View commit details
    Browse the repository at this point in the history

  3. Revert "Test out substituteType approach" 

    This reverts commit d4cf721.
    @JordanMartinez
    JordanMartinez committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    fa7235f View commit details
    Browse the repository at this point in the history

  4. Show master's output of added tests

    @JordanMartinez
    JordanMartinez committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    ed9bcd9 View commit details
    Browse the repository at this point in the history

  5. Revert "Show master's output of added tests" 

    This reverts commit ed9bcd9.
    @JordanMartinez
    JordanMartinez committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    0ae5f1f View commit details
    Browse the repository at this point in the history

  6. Commit output of dropping parU

    @JordanMartinez
    JordanMartinez committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    f9a8aad View commit details
    Browse the repository at this point in the history

  7. Simplify using parU to get all errors

    @JordanMartinez
    JordanMartinez committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    7a160d4 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/master' into types-do-not-unify-… 

    …row-type-clearification
    @JordanMartinez
    JordanMartinez committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    48516ea View commit details
    Browse the repository at this point in the history

  9. Use parU to fix multi errors in 1 row test

    @JordanMartinez
    JordanMartinez committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    958c954 View commit details
    Browse the repository at this point in the history

  10. Add another test showing shared/unshared labels

    @JordanMartinez
    JordanMartinez committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    25b8c10 View commit details
    Browse the repository at this point in the history

  11. Cleanup comments

    @JordanMartinez
    JordanMartinez committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    c7566f9 View commit details
    Browse the repository at this point in the history

  12. Rework unifyRows error handling

    @rhendric
    rhendric committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    f7ec585 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Generalize unifyRows to unifyishRows 

    Moved to its own module
- so that `Kinds.hs` can import it
- because `L.PS.Types.hs` works on `Type a`, not `SourceType`
- because operation is no longer just unification
    @JordanMartinez
    JordanMartinez committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    cb9031a View commit details
    Browse the repository at this point in the history

  2. Update subsumes to use unifyishRows 

    - `data-ordlist` dep is no longer used
    @JordanMartinez
    JordanMartinez committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    5bae146 View commit details
    Browse the repository at this point in the history

  3. Add Ryan's kind unification test

    @JordanMartinez
    JordanMartinez committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    14702f7 View commit details
    Browse the repository at this point in the history

  4. Update unifyKindsWithFailure to use unifyishRows sometimes

    @JordanMartinez
    JordanMartinez committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    f70c8d9 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. A little fussing before the action

    @rhendric
    rhendric committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    93617e1 View commit details
    Browse the repository at this point in the history

  2. Refactor record subsumption, unifyRows

    @rhendric
    rhendric committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    5fa4ea0 View commit details
    Browse the repository at this point in the history

  3. Add used-x-expected-y bit to TypesDoNotUnify

    @rhendric
    rhendric committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    b80d3d3 View commit details
    Browse the repository at this point in the history

  4. Rework checkProperties

    @rhendric
    rhendric committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    de51a65 View commit details
    Browse the repository at this point in the history

  5. Update tests 

    Deleted RowOneMissingLabel because it's covered by the existing
MissingRecordField
    @rhendric
    rhendric committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    28f4dff View commit details
    Browse the repository at this point in the history

  6. Error improvement: drop redundant subsumption hint

    @rhendric
    rhendric committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    7202333 View commit details
    Browse the repository at this point in the history

  7. Error improvement: diff records like rows

    @rhendric
    rhendric committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    d02efa1 View commit details
    Browse the repository at this point in the history

  8. Error improvement: display empty records as such

    @rhendric
    rhendric committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    6acdd99 View commit details
    Browse the repository at this point in the history

  9. Appease HLint

    @rhendric
    rhendric committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    7ceba4c View commit details
    Browse the repository at this point in the history

  10. Update Kinds to always use unifyishRows

    @JordanMartinez
    JordanMartinez committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    97b6b86 View commit details
    Browse the repository at this point in the history

  11. Use actual/expected terminology

    @JordanMartinez
    JordanMartinez committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    9b54c4c View commit details
    Browse the repository at this point in the history

  12. Merge remote-tracking branch 'origin/master' into better-unify-row-er… 

    …ror-messages
    @JordanMartinez
    JordanMartinez committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    cee90c4 View commit details
    Browse the repository at this point in the history

  13. First attempt at changelog entry

    @JordanMartinez
    JordanMartinez committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    75aa382 View commit details
    Browse the repository at this point in the history

  14. Update entry: apparent pattern matching inconsistency

    @JordanMartinez
    JordanMartinez committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    09567b6 View commit details
    Browse the repository at this point in the history

  15. Use 'expected but found' terminology

    @JordanMartinez
    JordanMartinez committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    5b56006 View commit details
    Browse the repository at this point in the history

  16. Use Ryan's suggestion to merge cases 2-4

    @JordanMartinez
    JordanMartinez committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    6b60710 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Fix 'expected/actual' header text; reword opening

    @JordanMartinez
    JordanMartinez committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    2094d75 View commit details
    Browse the repository at this point in the history