Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockstring #599

Merged
merged 1 commit into from
Sep 19, 2014
Merged

Blockstring #599

merged 1 commit into from
Sep 19, 2014

Conversation

phadej
Copy link
Contributor

@phadej phadej commented Sep 15, 2014

This could be handy for FFI.

Motivation: I tried to re-use a javascript function with regex with double quotes. Multiple escaping drove me insane

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling ad2988d on phadej:blockstring into 873b829 on purescript:master.

@andreypopp
Copy link
Contributor

👍 wanted this for so long

@michaelficarra
Copy link
Contributor

👍 Nice!

@paf31
Copy link
Contributor

paf31 commented Sep 15, 2014

This looks nice. I don't see any reasons why there would be any issues with it, but let me pull your changes and try it out briefly.

@paf31
Copy link
Contributor

paf31 commented Sep 19, 2014

Resolves #602.

paf31 added a commit that referenced this pull request Sep 19, 2014
@paf31 paf31 merged commit 531e1e3 into purescript:master Sep 19, 2014
@paf31
Copy link
Contributor

paf31 commented Sep 19, 2014

Thanks!

@garyb
Copy link
Member

garyb commented Sep 19, 2014

🍰

@phadej phadej deleted the blockstring branch September 19, 2014 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants